Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repository for hashicorp/consul, and disable the consul-consul-client #2764

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Add repository for hashicorp/consul, and disable the consul-consul-client #2764

merged 1 commit into from
Oct 17, 2022

Conversation

gongmax
Copy link
Collaborator

@gongmax gongmax commented Oct 15, 2022

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

  • Add repository for hashicorp/consul, and disable the consul-consul-client
  • Wire the GCP_PROJECT up to clean-gcloud-e2e-test-cluster target

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c3d366ec-9de6-46a7-9b59-5f09fa1b5cda

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2764/head:pr_2764 && git checkout pr_2764
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.27.0-68dba2f-amd64

@gongmax gongmax marked this pull request as ready for review October 15, 2022 01:19
markmandel
markmandel approved these changes Oct 17, 2022
View reviewed changes
build/terraform/e2e/module.tf
chart = "hashicorp/consul"
name = "consul"
repository = "https://helm.releases.hashicorp.com"
chart = "consul"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually very confused as to why it's not "hashicorp/consul" (since that's what the docs say), but as long as it works, I don't mind! 😄

@google-oss-prow google-oss-prow bot added the lgtm label Oct 17, 2022
@markmandel markmandel merged commit b68324f into googleforgames:main Oct 17, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongmax gongmax deleted the consul branch October 17, 2022 21:27
@mangalpalli mangalpalli added this to the 1.27.0 milestone Oct 18, 2022
@gongmax gongmax mentioned this pull request Nov 29, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@markmandel markmandel

Labels
approved lgtm size/S
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gongmax @agones-bot @markmandel @mangalpalli